Merged
Conversation
This reverts commit 16f3064.
this took me literally all day but im happy to contribute :))))) pls dont close my pr and put notes of what youd want to change i would literally kill myself if this was made for no reason and i just wasted my time. i tried to make it as prod ready as posibel 👍
Member
|
I'm a little concerned, I haven't read much of the code, but it still seems way too complex. The whole custom heuristic strategy seems unnecessary, but I'm not exactly sure. While testing it seems it walks through blocks? I assume this is only a base at the end of the day, but I can barely understand the structure (I am a complete idiot though), and still seems way too complex for just a Minecraft pathfinder. Sorry if I seem stubborn, I'm just struggling to understand. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this took me literally all day but im happy to contribute :))))) pls dont close my pr and put notes of what youd want to change i would literally kill myself if this was made for no reason and i just wasted my time. i tried to make it as prod ready as posibel 👍